[GlobalOpt] Disable pack->expand_shape propagation. #17739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not enabled until the upstream commit: llvm/llvm-project@a945f55 The upstream commit triggers a bug in IREE, so the revision disables the propagation. Signed-off-by: hanhanW <[email protected]>
ScottTodd
approved these changes
Jun 25, 2024
Signed-off-by: hanhanW <[email protected]>
I need to check the benchmark results. We also need a better way to control the propagation, I'll help update it. |
hanhanW
added
benchmarks:x86_64
|
Merging the PR to unblock other work. I'll follow up on this. |
LLITCHEV
pushed a commit
to LLITCHEV/iree
that referenced
this pull request
Jul 30, 2024
It is not enabled until the upstream commit: llvm/llvm-project@a945f55 The upstream commit triggers a bug in IREE, so the revision disables the propagation. See iree-org#17734 for more details. --------- Signed-off-by: hanhanW <[email protected]> Signed-off-by: Lubo Litchev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not enabled until the upstream commit: llvm/llvm-project@a945f55
The upstream commit triggers a bug in IREE, so the revision disables the propagation.
See #17734 for more details.