Specify realnames must not be empty. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All known servers reject ERR_NEEDMOREPARAMS, except ircu2, which uses a default value.
DanielOaks
reviewed
Aug 16, 2021
Co-authored-by: Daniel Oaks <[email protected]>
|
Should we recommend clients to set the username to the same value as the nickname if unspecified by the user? |
|
This feels out of scope |
|
I must say, my main gripe is clients setting username/realname to the client name. This makes it extremely difficult to figure out whether the username/realname has been user-set or not. |
|
Why do you need/want to know that? Anyway, that's not what this PR is about; could you open an issue to discuss it? |
|
Sure, done in #126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All known servers reject with ERR_NEEDMOREPARAMS, except ircu2, which uses a
default value.
Closes GH-85