Fix #133 #136
Merged
Fix #133 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orottier
approved these changes
Sep 7, 2024
|
|
||
| const event = new jsExport.OfflineAudioCompletionEvent(rawEvent.type, { | ||
| renderedBuffer: this.#renderedBuffer, | ||
| }); | ||
|
|
||
| propagateEvent(this, event); | ||
| // delay event propagation to next tick that it is executed after startRendering fulfills | ||
| setTimeout(() => { |
There was a problem hiding this comment.
I think setTimeout(.., 0) can be expressed more efficiently with setImmediate
There was a problem hiding this comment.
Yup thanks, sure I have been misleaded by mdn which marks it deprecated but it doesn't stand in node context
| @@ -1,4 +1,6 @@ | |||
| #![deny(clippy::all)] | |||
| // @todo - properly fix this clippy issue | |||
| #![allow(clippy::zero_repeat_side_effects)] | |||
There was a problem hiding this comment.
meh, I think this is a napi issue causing false positive in clippy
There was a problem hiding this comment.
Yup I agree, let's see if the problem disappear in a future napi-rs release, I opened an issue to not forget that
cf. #137
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.