Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer bugfix #915

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Timer bugfix #915

merged 2 commits into from
Dec 8, 2023

Conversation

ywc689
Copy link
Collaborator

@ywc689 ywc689 commented Sep 19, 2023

No description provided.

@ywc689
timer: fix timeout over about 524s do not work as expected
af249ea 
The problem is revealed by yangxingwu in pr iqiyi#901 and the fix
is fetched from pr iqiyi#29 authored by yangxingwu.
@ywc689
test: update timer accuracy test program
d11db88 
Signed-off-by: ywc689 <[email protected]>
@ywc689 ywc689 added the pr/to-review-codes review codes line by line and check if problem exists. label Sep 19, 2023
ytwang0320
ytwang0320 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@ytwang0320 ytwang0320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve +1

@ywc689 ywc689 added pr/codes-reviewed-ok code review passed and no problem found pr/accepted the pr passed all review stages and await to be merged and removed pr/to-review-codes review codes line by line and check if problem exists. labels Dec 4, 2023
@ywc689 ywc689 merged commit 12ef8a9 into iqiyi:devel Dec 8, 2023
9 checks passed
@ywc689 ywc689 deleted the timer-bugfix branch July 10, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytwang0320 ytwang0320 ytwang0320 approved these changes

@you-looks-not-tasty you-looks-not-tasty Awaiting requested review from you-looks-not-tasty

Assignees
No one assigned
Labels
pr/accepted the pr passed all review stages and await to be merged pr/codes-reviewed-ok code review passed and no problem found
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ywc689 @ytwang0320