Skip to content

Commit

Permalink
[pci] Drag in PCI settings mechanism only when PCI support is present
Browse files Browse the repository at this point in the history
Allow for the existence of platforms with no PCI bus by including the
PCI settings mechanism only if PCI bus support is included.

Signed-off-by: Michael Brown <[email protected]>
  • Loading branch information
mcb30 committed Oct 25, 2024
1 parent abfa7c3 commit cc45ca3
Show file tree
Hide file tree
Showing 3 changed files with 42 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/config/config.c
Original file line number Diff line number Diff line change
Expand Up @@ -352,9 +352,6 @@ REQUIRE_OBJECT ( efi_bofm );
/*
* Drag in relevant settings sources
*/
#ifdef PCI_SETTINGS
REQUIRE_OBJECT ( pci_settings );
#endif
#ifdef VMWARE_SETTINGS
REQUIRE_OBJECT ( guestinfo );
#endif
Expand Down
36 changes: 36 additions & 0 deletions src/config/config_pci.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
/*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
* 02110-1301, USA.
*
* You can also choose to distribute this program under the terms of
* the Unmodified Binary Distribution Licence (as given in the file
* COPYING.UBDL), provided that you have satisfied its requirements.
*/

FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );

#include <config/settings.h>

/** @file
*
* PCI configuration options
*
*/

PROVIDE_REQUIRING_SYMBOL();

#ifdef PCI_SETTINGS
REQUIRE_OBJECT ( pci_settings );
#endif
6 changes: 6 additions & 0 deletions src/drivers/bus/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -438,3 +438,9 @@ struct root_device pci_root_device __root_device = {
.dev = { .name = "PCI" },
.driver = &pci_root_driver,
};

/* Drag in objects via pcibus_probe() */
REQUIRING_SYMBOL ( pcibus_probe );

/* Drag in PCI configuration */
REQUIRE_OBJECT ( config_pci );

0 comments on commit cc45ca3

Please sign in to comment.