Update websocket relay example app #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgins
force-pushed
the
bgins/update-examples
branch
from
1a496ae to
86af270
Compare
avivash
approved these changes
Nov 21, 2023
Ah yeah, good call! Updated. 👌 |
hugomrdias
requested changes
Nov 22, 2023
|
Where they just missing in package.json I don't see new imports for them in
this PR
Hugo Dias
…On Wed, Nov 22, 2023, 18:23 Brian Ginsburg ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In examples/websocket-relay/relay-app/package.json
<#448 (comment)>:
> + "iso-base": "^2.0.1",
+ "multiformats": "^12.1.3",
multiformats is used for CID when constructing workflows, for example:
https://github.com/ipvm-wg/homestar/blob/73f7955c70a59da43ac936a0e1518d785264eb25/examples/websocket-relay/relay-app/src/lib/workflow.ts#L265-L267
This field reported a type error when attempting to use a string.
iso-base is used for converting the Uint8array in a receipt to base64:
https://github.com/ipvm-wg/homestar/blob/73f7955c70a59da43ac936a0e1518d785264eb25/examples/websocket-relay/relay-app/src/lib/workflow.ts#L233
—
Reply to this email directly, view it on GitHub
<#448 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACMWTRDNO3FT2OL44IE2IDYFY7LTAVCNFSM6AAAAAA7VGONZKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBVGA4DINZXHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
bgins
commented
Nov 22, 2023
hugomrdias
requested changes
Nov 22, 2023
hugomrdias
requested changes
Nov 27, 2023
hugomrdias
approved these changes
Nov 27, 2023
|
@bgins this all looks great. One minor change maybe. Since we have the option to not pass settings anymore, and we don't really use it in the example, can we update to go that direction for the example (as easy as possible?)? |
zeeshanlakhani
approved these changes
Nov 28, 2023
| const data = await event.data.text(); | ||
|
|
||
| export async function handleMessage( | ||
| data: MaybeResult<WorkflowNotification, WorkflowNotificationError> |
There was a problem hiding this comment.
MaybeResult is nice +1.
Co-authored-by: Hugo Dias <[email protected]> Signed-off-by: Brian Ginsburg <[email protected]>
bgins
force-pushed
the
bgins/update-examples
branch
from
d486c1d to
dd4d367
Compare
Yeah, good idea! Added that. |
zeeshanlakhani
pushed a commit
that referenced
this pull request
Nov 29, 2023
This PR implements the following changes: - [x] Update example to use Homestar client: https://www.npmjs.com/package/@fission-codes/homestar - [x] Remove emulation mode Implements #390 - [x] Refactor (non-breaking change that updates existing functionality) The example should be tested manually to verify it works. --------- Signed-off-by: Brian Ginsburg <[email protected]> Co-authored-by: Hugo Dias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the following changes:
Link to issue
Implements #390
Type of change
Test plan (required)
The example should be tested manually to verify it works.