Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DX: JSON-RPC Interface for running workflows, returning receipts, pushing events #390

Closed
5 tasks done
Tracked by #331
, #417
...
zeeshanlakhani opened this issue Oct 19, 2023 · 2 comments
Closed
5 tasks done
Tracked by #331
, #417
...

DX: JSON-RPC Interface for running workflows, returning receipts, pushing events #390

zeeshanlakhani opened this issue Oct 19, 2023 · 2 comments
Assignees
@zeeshanlakhani @bgins
Labels
dx Developer experience applications and improvements

Comments

@zeeshanlakhani
Copy link
Contributor

zeeshanlakhani commented Oct 19, 2023 •
edited by bgins
Loading

Summary

We need a standardized JSON-RPC implementation for handling web socket and HTTP interaction to integrate with the dashboard and any application.

Components

ETA: 2023-11-03
@zeeshanlakhani zeeshanlakhani added the dx Developer experience applications and improvements label Oct 19, 2023
@zeeshanlakhani zeeshanlakhani self-assigned this Oct 19, 2023
@zeeshanlakhani zeeshanlakhani changed the title JSON-RPC Interface for running workflows, returning receipts, pushing events DX: JSON-RPC Interface for running workflows, returning receipts, pushing events Oct 19, 2023
@zeeshanlakhani zeeshanlakhani mentioned this issue Oct 19, 2023
Open
18 tasks
This was referenced Oct 31, 2023
Closed
Closed
@expede expede mentioned this issue Oct 31, 2023
Closed
@zeeshanlakhani
Copy link
Contributor Author

Only thing left is updating the example to not break (needs a client).

@bgins bgins self-assigned this Nov 16, 2023
This was referenced Nov 16, 2023
Merged
Merged
bgins added a commit that referenced this issue Nov 28, 2023
@bgins @hugomrdias
Update websocket relay example app (#448)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1c823b8 
# Description

This PR implements the following changes:

- [x] Update example to use Homestar client:
https://www.npmjs.com/package/@fission-codes/homestar
- [x] Remove emulation mode

## Link to issue

Implements #390

## Type of change

- [x] Refactor (non-breaking change that updates existing functionality)

## Test plan (required)

The example should be tested manually to verify it works.

---------

Signed-off-by: Brian Ginsburg <[email protected]>
Co-authored-by: Hugo Dias <[email protected]>
zeeshanlakhani pushed a commit that referenced this issue Nov 29, 2023
@bgins @hugomrdias @zeeshanlakhani
Update websocket relay example app (#448)
7c45cf5 
This PR implements the following changes:

- [x] Update example to use Homestar client:
https://www.npmjs.com/package/@fission-codes/homestar
- [x] Remove emulation mode

Implements #390

- [x] Refactor (non-breaking change that updates existing functionality)

The example should be tested manually to verify it works.

---------

Signed-off-by: Brian Ginsburg <[email protected]>
Co-authored-by: Hugo Dias <[email protected]>
bgins added a commit that referenced this issue Nov 29, 2023
@bgins @hugomrdias
jsonrpc-feature returned (#417)
ac9167c 
## Description

Includes:
  - re-purposing of feature flags 
    * metrics is always a thing (on) 
    * monitoring is the gated feature 
    * The websocket-server flag is gone, we only gate push notifications
  - JSON-RPC setup and RPC method register
  - Prometheus exposition format to JSON parser

Other features and other fixes:

- [x] e2e testing of run workflow
- [x] #407
- [x] #410
- [x] #418
- [x] #424
- [x] #354 
- [x] #409
- [x] #425 
- [x] #426
- [x] #429 
- [x] #433
- [x] #435
- [x] #421
- [x] #436
- [x] #437
- [x] #444
- [x] #438
- [x] #390
- [x] #451 
- [x] #456

---------

Signed-off-by: Brian Ginsburg <[email protected]>
Signed-off-by: Zeeshan Lakhani <[email protected]>
Co-authored-by: Brian Ginsburg <[email protected]>
Co-authored-by: Hugo Dias <[email protected]>
bgins added a commit that referenced this issue Nov 29, 2023
@bgins @hugomrdias
feat: Add JSON-PRC API (#417)
9b67136 
Includes:
  - re-purposing of feature flags
    * metrics is always a thing (on)
    * monitoring is the gated feature
    * The websocket-server flag is gone, we only gate push notifications
  - JSON-RPC setup and RPC method register
  - Prometheus exposition format to JSON parser

Other features and other fixes:

- [x] e2e testing of run workflow
- [x] #407
- [x] #410
- [x] #418
- [x] #424
- [x] #354
- [x] #409
- [x] #425
- [x] #426
- [x] #429
- [x] #433
- [x] #435
- [x] #421
- [x] #436
- [x] #437
- [x] #444
- [x] #438
- [x] #390
- [x] #451
- [x] #456

---------

Signed-off-by: Brian Ginsburg <[email protected]>
Signed-off-by: Zeeshan Lakhani <[email protected]>
Co-authored-by: Brian Ginsburg <[email protected]>
Co-authored-by: Hugo Dias <[email protected]>
@bgins
Copy link
Contributor

bgins commented Nov 30, 2023

Closed by #417

@bgins bgins closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeeshanlakhani zeeshanlakhani

@bgins bgins

Labels
dx Developer experience applications and improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zeeshanlakhani @bgins