-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the s.mxtv.jp
and www.skyperfectv.co.jp
sites and mapping IDs for tvguide.myjcom.jp
#2409
Conversation
…ikkei CNBC, Pachinko Pachislo and GSTV [add] adding TSS from JCOM
Marked as ready to merge since I successfully tested the two new parsers and there were no issues. |
s.mxtv.jp, skyperfectv.co.jp and tvguide.myjcom.jp all passed the test. skyperfectv.co.jp is returning an unexpected output when ran using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't test the channel output for now, though a few remarks :
- While it's coming from a good intention to add a README on the SkyPerfect and s.mxtv folder, we simply do not do per-site READMEs
- Simply call it "skyperfect.co.jp", will be easier for all of us I guess.
- I suppose the yarn.lock change is linked to your computer, though I do not know if it's a needed change in GH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the “www” from the file names of the “skyperfectv.co.jp” to match the rest of the files in the repository and roll back the changes to the yarn.lock file.
Otherwise everything looks fine to me.
I left the
Yup I'll do that just now.
To be honest I just copied the structure of an already existing site folder. |
And for the |
Don't change it in the code if it's necessary, just the folder name, in order to fit the naming standard we have. |
Certain NSFW (18+) channels are excluded from the EPG data because there's a confirmation needed. A cookie should be added in order to make sure it doesn't give incomplete data. |
Here's the code that works, on my side :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failed:
npm test -- skyperfectv.co.jp
> test
> run-script-os skyperfectv.co.jp
> test:default
> TZ=Pacific/Nauru npx jest --runInBand skyperfectv.co.jp
RUNS sites/skyperfectv.co.jp/skyperfectv.co.jp.test.js
/Users/Arhey/Code/iptv-org/epg/sites/skyperfectv.co.jp/skyperfectv.co.jp.config.js:36
const sched = await this.fetchSchedule({ date, channel });
^
TypeError: Cannot read properties of undefined (reading 'fetchSchedule')
at parser (/Users/Arhey/Code/iptv-org/epg/sites/skyperfectv.co.jp/skyperfectv.co.jp.config.js:36:34)
at Object.<anonymous> (/Users/Arhey/Code/iptv-org/epg/sites/skyperfectv.co.jp/skyperfectv.co.jp.test.js:25:18)
at Promise.then.completed (/Users/Arhey/Code/iptv-org/epg/node_modules/jest-circus/build/utils.js:298:28)
at new Promise (<anonymous>)
at callAsyncCircusFn (/Users/Arhey/Code/iptv-org/epg/node_modules/jest-circus/build/utils.js:231:10)
at _callCircusTest (/Users/Arhey/Code/iptv-org/epg/node_modules/jest-circus/build/run.js:316:40)
at _runTest (/Users/Arhey/Code/iptv-org/epg/node_modules/jest-circus/build/run.js:252:3)
at _runTestsForDescribeBlock (/Users/Arhey/Code/iptv-org/epg/node_modules/jest-circus/build/run.js:126:9)
at run (/Users/Arhey/Code/iptv-org/epg/node_modules/jest-circus/build/run.js:71:3)
at runAndTransformResultsToJestFormat (/Users/Arhey/Code/iptv-org/epg/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
at jestAdapter (/Users/Arhey/Code/iptv-org/epg/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
at runTestInternal (/Users/Arhey/Code/iptv-org/epg/node_modules/jest-runner/build/runTest.js:367:16)
at runTest (/Users/Arhey/Code/iptv-org/epg/node_modules/jest-runner/build/runTest.js:444:34)
Node.js v18.18.2
@Animenosekai - |
@PopeyeTheSai10r Should work fine now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for s.mxtv.jp, their website is so counterintuitive...
All the necessary stuff you should find it in https://s.mxtv.jp/bangumi/js/common_bangumi.js?20240311 / https://s.mxtv.jp/bangumi/js/timetable.js?20240820
@Animenosekai what you can try is this :
GET https://s.mxtv.jp/bangumi/link/weblinkU.csv?1728896511558 & https://s.mxtv.jp/bangumi/link/weblinkU_ir.csv?1728896511558 (timestamp in epoch, Asia/Tokyo TZ), compare the names in your EPG result with the ones in this CSV, GET the image linked to said line based on program name. It will need some CSV parsing.
You may also use a library like "didyoumean2", that'll use the Levenshtein algorithm to get the closest name it can find if it isn't a perfect match. I cannot try it as I'm not a Japanese speaker myself, so I believe you'll be luckier than me if it works fine on your side.
Hello !
Note
This was made upon a request from the issue Animenosekai/japanterebi-xmltv#1
I've just created two new parsers for the sites/sources:
s.mxtv.jp
: Providing EPG data for Tokyo MX1 and Tokyo MX2 (which was missing previously)www.skyperfectv.co.jp
: Providing EPG data for a bunch of specific or paid channelsI also added TSS from JCOM and matched the following IDs from JCOM:
Important
This does not add any dependency since the repository already depends on
cheerio
,axios
anddayjs