Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update channels #13427

Merged
merged 9 commits into from
Oct 7, 2024
Merged

Update channels #13427

merged 9 commits into from
Oct 7, 2024

Conversation

davidclaeysquinones
Copy link
Contributor

I've changed the icon for ViaplayTv to a png as previously requested and added another additional channel.

@shikenie

This comment was marked as off-topic.

@davidclaeysquinones
Copy link
Contributor Author

Of course there is, but I'm trying to limit the scope of my PR in order to get it approved.
I'm having some issues getting them approved so I kinda don't want to take the risk.

@Dum4G
Copy link
Contributor

Dum4G commented Sep 30, 2024

image
Please use issue template for editing individual channels. PR is too easy to mess up

@Dum4G Dum4G closed this Sep 30, 2024
@davidclaeysquinones
Copy link
Contributor Author

The reason I didn't filed an issue is that I wanted to help out.
It seemed more reasonable to submit an individual change rather than ask for it.
I'm sorry if my actions had the opposite effect.
I've made some changes to my PR and run them through the validate script.
It seems like now there are no issues.

@Dum4G Dum4G reopened this Oct 4, 2024
Dum4G
Dum4G previously approved these changes Oct 4, 2024
BellezaEmporium

This comment was marked as outdated.

Copy link
Contributor

@BellezaEmporium BellezaEmporium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erh, wait, not LGTM. ViaplayTV is not supposed to be mixed with the SBS channels, it should be a bit below. Have you checked if there wasn't a duplicate ?

@davidclaeysquinones
Copy link
Contributor Author

The SBS channel was replaced by Viaplay.
This link proves what i'm saying.

@BellezaEmporium
Copy link
Contributor

The SBS channel was replaced by Viaplay. This link proves what i'm saying.

What I meant is that we keep an alphabetical order in our CSV file, and Viaplay TV, whilst it is a replacement of SBS9, should be classified in the V list.

By the way, instead of removing SBS9, the best practice would be to say it was closed at a certain date, and replaced by Viaplay TV. Makes things easier to understand for everyone.

@davidclaeysquinones
Copy link
Contributor Author

davidclaeysquinones commented Oct 5, 2024

I filled in the replaced by column but not the closed column. I'll make those changes and put Viaplay by alphabetical order.

@davidclaeysquinones
Copy link
Contributor Author

I've just implemented the proposed changes.

@BellezaEmporium
Copy link
Contributor

LGTM. Thank you.

@Dum4G Dum4G merged commit 9eb0e41 into iptv-org:master Oct 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants