-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update channels #13427
Update channels #13427
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Of course there is, but I'm trying to limit the scope of my PR in order to get it approved. |
The reason I didn't filed an issue is that I wanted to help out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erh, wait, not LGTM. ViaplayTV is not supposed to be mixed with the SBS channels, it should be a bit below. Have you checked if there wasn't a duplicate ?
The SBS channel was replaced by Viaplay. |
What I meant is that we keep an alphabetical order in our CSV file, and Viaplay TV, whilst it is a replacement of SBS9, should be classified in the V list. By the way, instead of removing SBS9, the best practice would be to say it was closed at a certain date, and replaced by Viaplay TV. Makes things easier to understand for everyone. |
I filled in the replaced by column but not the closed column. I'll make those changes and put Viaplay by alphabetical order. |
I've just implemented the proposed changes. |
LGTM. Thank you. |
I've changed the icon for ViaplayTv to a png as previously requested and added another additional channel.