Dell OS10: Don't enable IPv6 for L2-only interfaces or VLANs #1870
Conversation
jbemmel
force-pushed
the
dellos10_disable_ipv6_l2
branch
from
af43ef9 to
e7d4382
Compare
There was a problem hiding this comment.
The title of the commit says "IPv6 something something on OS10", and then you modify an integration test. Is it so hard to keep the two separate?
Also, I would add the "wait for RA" step before IPv6 ping in the integration test, which, if you want to go down that path, goes into a separate commit.
The modification to the integration test is a separate commit, do you mean you'd like a separate PR? I put them together because the modification of the test serves to test the changes included in the PR |
Yes. When we merge the PR, the commits get squashed. Nobody wants to see the "I fixed a typo" commit messages.
While I understand why you feel that way today, somebody trying to figure out why the integration test changed in a OS10 config template fix a year from now might disagree. |
… except LAG related interfaces such as peerlinks, port-channels and lag member interfaces
…ce (avoid misconceptions) * Remove VLAN ipv6 settings, no IPv6 LLA address is allocated in case of virtual network
jbemmel
force-pushed
the
dellos10_disable_ipv6_l2
branch
from
4805616 to
a996049
Compare
Expand the types of interfaces for which to disable ipv6: Everything except LAG related interfaces such as peerlinks, port-channels and lag member interfaces.
NB L2-only interfaces include bridged VLANs
Fixes #1868
Clear counters on virtual network interfaces (they remain 0)
Tested using OS Version 10.5.6.5 on clab:
lag/11-mlag-anycast.ymlvlan/21-vlan-irb-single.ymlvlan/22-vlan-irb-multiple.yml(modified to add ipv6 tests in separate PR)vlan/41-vlan-bridge-native.ymlNote: Only one of the VLAN integration tests includes ipv6 testing (21), and not between hosts - I figured it would be good to add one more