Cumulus NVUE: Fix case of custom loopbacks with OSPF #1834
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra loopbacks are a problem with NVUE, due to its over-simplified model of having a single loopback interface "lo"
This fix is not great, could add a quirk to detect unsupported combinations, e.g. multiple loopbacks with different OSPF areas, or declare custom loopbacks unsupported in combination with OSPF. Not to be merged as-is, only a starting point for discussion
Not sure if VRF loopbacks could get advertised in OSPF at all
The OSPF module adds the area to the loopback interface, so I removed the custom area inclusion from the template.
Fixes #1836