Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulus NVUE: Fix case of custom loopbacks with OSPF #1834

Closed
wants to merge 1 commit into from

Conversation

jbemmel
Copy link
Collaborator

@jbemmel jbemmel commented Jan 25, 2025

Extra loopbacks are a problem with NVUE, due to its over-simplified model of having a single loopback interface "lo"

This fix is not great, could add a quirk to detect unsupported combinations, e.g. multiple loopbacks with different OSPF areas, or declare custom loopbacks unsupported in combination with OSPF. Not to be merged as-is, only a starting point for discussion

Not sure if VRF loopbacks could get advertised in OSPF at all

The OSPF module adds the area to the loopback interface, so I removed the custom area inclusion from the template.

Fixes #1836

Could add a quirk to detect unsupported combinations, e.g. multiple loopbacks with different OSPF areas
@jbemmel jbemmel marked this pull request as draft January 25, 2025 05:28
@ipspace
Copy link
Owner

ipspace commented Jan 25, 2025

Extra loopbacks are a problem with NVUE, due to its over-simplified model of having a single loopback interface "lo"

Junos is very similar, so whatever we do for one, we can also do for the other.

This fix is not great, could add a quirk to detect unsupported combinations, e.g. multiple loopbacks with different OSPF areas, or declare custom loopbacks unsupported in combination with OSPF.

I would allow solve it with a quirk (like with Junos). Right now, Junos quirk throws an "unsupported" error, but we could make that configurable (working on "disable error-generating quirks" right now) and in case the error is not thrown collect all loopback IPs, add them to _ipv4 and _ipv6 (or something similar) on node.loopback, and potentially generate a warning about what we did.

Not sure if VRF loopbacks could get advertised in OSPF at all

Yes they can.

@jbemmel
Copy link
Collaborator Author

jbemmel commented Jan 25, 2025

Not sure if VRF loopbacks could get advertised in OSPF at all

Yes they can.

I mean not sure if it would work using NVUE, it offers functionality to configure an IP as 'loopback' for a VRF but I haven't seen a way to configure its OSPF area for example

@jbemmel
Copy link
Collaborator Author

jbemmel commented Feb 2, 2025

Fixed in #1832

@jbemmel jbemmel closed this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cumulus NVUE fails to handle additional loopbacks with OSPF
2 participants