BUGFIX: Groups may include 'bool' flags, test for that

ipspace · Dec 6, 2024 · 45e78fe · 45e78fe
1 parent 287dc22
commit 45e78fe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/netsim/extra/repeater/plugin.py b/netsim/extra/repeater/plugin.py
@@ -68,7 +68,7 @@ def repeat_node(node: Box, topology: Box) -> None:
 
   if 'groups' in topology:
     for group in topology.groups.values():
-      if node.name in group.members:
+      if isinstance(group,dict) and node.name in group.get('members',[]):   # Groups can include 'bool flags too
         group.members.extend( clones )
 
   if 'vlans' in topology:

diff --git a/tests/topology/input/repeater-plugin.yml b/tests/topology/input/repeater-plugin.yml
@@ -8,6 +8,7 @@ vlans:
   links: [r-h]  # VLAN links get updated
 
 groups:
+ _auto_create: True # Test presence of bool flag
  hosts:
   members: [h]  # Gets updated with cloned nodes
-Original file line number
+Diff line change
@@ Expand Up / @@ -8,6 +8,7 @@ vlans: @@
       links: [r-h]  # VLAN links get updated
     groups:
+     _auto_create: True # Test presence of bool flag
      hosts:
       members: [h]  # Gets updated with cloned nodes
@@ Expand Down @@