-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use new multiformats CID interface and exports #7
Draft
rvagg
wants to merge
2
commits into
master
Choose a base branch
from
rvagg/multiformats-cid-interface
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,35 +1,43 @@ | ||
import { TransactionInCoinbasePorcelain, TransactionInPorcelain } from 'bitcoin-block/classes/TransactionIn'; | ||
import { BlockHeaderPorcelain, TransactionPorcelain } from 'bitcoin-block/interface' | ||
import { CID } from 'multiformats'; | ||
import { CID } from 'multiformats/interface'; | ||
|
||
export type HASH_ALG_CODE = 0x56 | ||
export type CODEC_BLOCK_CODE = 0xb0 | ||
export type CODEC_TX_CODE = 0xb1 | ||
export type CODEC_WITNESS_COMMITMENT_CODE = 0xb2 | ||
|
||
export type IPLDLoader = (cid:CID)=>Promise<Uint8Array> | ||
|
||
export interface BitcoinBlockCID extends CID<CODEC_BLOCK_CODE, HASH_ALG_CODE, 1>{} | ||
export interface BitcoinTxCID extends CID<CODEC_TX_CODE, HASH_ALG_CODE, 1>{} | ||
export interface BitcoinWitnessCommitmentCID extends CID<CODEC_WITNESS_COMMITMENT_CODE, HASH_ALG_CODE, 1>{} | ||
|
||
export interface BitcoinHeader extends BlockHeaderPorcelain { | ||
parent: CID|null | ||
tx: CID | ||
parent: BitcoinBlockCID|null | ||
tx: BitcoinTxCID | ||
} | ||
|
||
export interface BitcoinTransactionMerkleNode { | ||
0: CID|null | ||
1: CID | ||
0: BitcoinTxCID|null | ||
1: BitcoinTxCID | ||
} | ||
|
||
|
||
export interface BitcoinTransactionInCoinbase extends TransactionInCoinbasePorcelain { | ||
tx: CID | ||
tx: BitcoinTxCID | ||
txinwitness: [string] | ||
} | ||
|
||
export interface BitcoinTransactionIn extends TransactionInPorcelain { | ||
tx: CID | ||
tx: BitcoinTxCID | ||
} | ||
|
||
export interface BitcoinTransaction extends TransactionPorcelain { | ||
witnessCommitment?: CID | ||
witnessCommitment?: BitcoinWitnessCommitmentCID | ||
vin: (BitcoinTransactionInCoinbase | BitcoinTransactionIn)[] | ||
} | ||
|
||
export interface BitcoinWitnessCommitment { | ||
witnessMerkleRoot: CID|null | ||
witnessMerkleRoot: BitcoinTxCID|null | ||
nonce: Uint8Array | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Diff may have end even smaller if you did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair, although there's so much hanging off
CID
now that I feel uncomfortable using it (a mental nit more than anything), includingCID.CID
.But if you were to make an example usage of the new CID API, would you advise
* as CID
or the specific pieces? Let's make this an exemplar that we can point to until we have more & better docs.