Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rework gateway page and add recursive gateway #1966

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

2color
Copy link
Member

@2color 2color commented Dec 6, 2024

Describe your changes

  • Clean up deprecated and unhelpful content
  • Add recursive/non-recursive to gateway types
  • Add trusted and trustless gateways to gateway types

Checklist before merging

  • Passing all required checks (The beta Check Markdown links for modified files check is not required)

@2color 2color requested review from lidel and bumblefudge December 6, 2024 15:46

### Your local gateway
## Gateway types
Copy link
Member Author

@2color 2color Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it makes sense to add a "gateway providers/http providers", as in providers from the IPNI exposing a non-recursive gateway

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleaning this up @2color, I found some easy wins while reading, suggestions below.

Most important is DNSLink section cleanup. If suggestions look goot to you, feel free to merge.

docs/concepts/ipfs-gateway.md Outdated Show resolved Hide resolved
docs/concepts/ipfs-gateway.md Outdated Show resolved Hide resolved
docs/concepts/ipfs-gateway.md Outdated Show resolved Hide resolved
docs/concepts/ipfs-gateway.md Outdated Show resolved Hide resolved
docs/concepts/ipfs-gateway.md Outdated Show resolved Hide resolved
docs/concepts/ipfs-gateway.md Outdated Show resolved Hide resolved
docs/concepts/ipfs-gateway.md Outdated Show resolved Hide resolved
docs/concepts/ipfs-gateway.md Outdated Show resolved Hide resolved
docs/concepts/ipfs-gateway.md Outdated Show resolved Hide resolved
docs/concepts/ipfs-gateway.md Outdated Show resolved Hide resolved
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I've adjusted required branch protections in this repo to require new fleek CI, hopefullu unblocking others to merge PRs in this repo (lmk if you get blocked again).

@lidel lidel merged commit abb58b8 into main Dec 10, 2024
4 checks passed
@lidel lidel deleted the recursive-gateways branch December 10, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants