Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add libp2p tracing metrics and server-timing headers #166 #183

Closed
wants to merge 4 commits into from

Conversation

shobit000
Copy link

Title

feat: add libp2p tracing metrics and expose via server-timing headers

Description

This PR integrates libp2p tracing metrics into the project and exposes these metrics via server-timing headers. It addresses the need for improved observability and performance monitoring. The changes include:

  • Adding @libp2p/opentelemetry-metrics to dependencies.

  • Initializing tracing metrics in libp2p-defaults.ts and libp2p-defaults.browser.ts.

  • Creating a new server.ts file to handle HTTP requests and expose server-timing headers.

Fixes [https://github.com//issues/166]

Notes & open questions

  • Ensure that the new tracing metrics do not introduce significant overhead.

  • Verify that the server-timing headers are correctly exposed in all relevant responses.

Change checklist

  • I have performed a self-review of my own code

  • I have made corresponding changes to the documentation if necessary (this includes comments as well)

  • I have added tests that prove my fix is effective or that my feature works

@shobit000 shobit000 requested a review from a team as a code owner February 20, 2025 12:53
@2color 2color closed this Feb 20, 2025
@2color
Copy link
Member

2color commented Feb 20, 2025

This looks like spam.

@shobit000
Copy link
Author

why ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants