-
Notifications
You must be signed in to change notification settings - Fork 11
change Block to a value struct #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The goal is to stop doing two allocations for each block (now it will only allocate the []byte buffer, and pass the cid.Cid, []byte pair by decomposed registers or stack). This way of changing does not change the syntax for trivial uses of block.Block, so in theory we will have to update only producers of block.Block, not consumers. Fixes #45 Replaces ipfs/boxo#192 Note: This change will cause a failure here: https://github.com/ipfs/go-ipld-format/blob/0f7aff00f72e9dea0d9718bc0972e309ba7c3e8d/format.go#L27
be42814
to
e82c533
Compare
This requires many changes in boxo, which passes a There are other places where more functionality is added to a block, or where something like an IPLD Node can be treated as a block, and a Removing the This PR is good for the purpose of forcing |
Triage notes:
|
Triage notes:
|
Recommend closing this PR, See explanation. |
The goal is to stop doing two allocations for each block (now it will only allocate the
[]byte
buffer, and pass thecid.Cid
,[]byte
pair by decomposed registers or stack).This way of changing does not change the syntax for trivial uses of
block.Block
, so in theory we will have to update only producers ofblock.Block
, not consumers.Fixes #45
Replaces ipfs/boxo#192
Note: This change will cause a failure here:
https://github.com/ipfs/go-ipld-format/blob/0f7aff00f72e9dea0d9718bc0972e309ba7c3e8d/format.go#L27