Remove want-block sent tracking from sessionWantSender #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracking want-blocks that were sent to a peer is not necessary to do in sessionwantsender. This is already handled in peermanager/peerwantmanager. Removing this tracking reduces unnecessary memory use.
gammazero
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #759 +/- ##
==========================================
- Coverage 60.46% 60.45% -0.02%
==========================================
Files 245 244 -1
Lines 31133 31101 -32
==========================================
- Hits 18826 18803 -23
+ Misses 10627 10618 -9
Partials 1680 1680
|
hsanjuan
reviewed
Jan 13, 2025
Comment on lines
-580
to
-584
| // Piggyback some other want-haves onto the request to the peer | ||
| for _, c := range sws.getPiggybackWantHaves(p, snd.wantBlocks) { | ||
| snd.wantHaves.Add(c) | ||
| } | ||
|
|
There was a problem hiding this comment.
Are we sure removing this has no effect?
swbt was introduced here: ipfs/go-bitswap@b3a47bc#diff-92a0b168d045013a05e87675741bb3cfa356a674c6f1535fbe88fc8e89d31e53
It is not explained what exactly motivated it, but it sounds like it is somehow keeping track of some wants that would otherwise not be sent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking want-blocks that were sent to a peer is not necessary to do in sessionwantsender. This is already handled in peermanager/peerwantmanager.
Removing this tracking reduces unnecessary memory use.