Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on goprocess #710

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Remove dependency on goprocess #710

merged 3 commits into from
Nov 7, 2024

Conversation

gammazero
Copy link
Contributor

The dependency on goprocess is not needed by boxo, and removing it removes the need to support it in code dependent on boxo.

Closes #709

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 71.22302% with 40 lines in your changes missing coverage. Please review.

Project coverage is 60.35%. Comparing base (98850cf) to head (19d1d6b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
bootstrap/bootstrap.go 39.62% 31 Missing and 1 partial ⚠️
bitswap/server/server.go 85.71% 5 Missing and 1 partial ⚠️
bitswap/client/client.go 81.81% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
- Coverage   60.38%   60.35%   -0.03%     
==========================================
  Files         243      243              
  Lines       31025    31021       -4     
==========================================
- Hits        18733    18724       -9     
- Misses      10625    10633       +8     
+ Partials     1667     1664       -3     
Files with missing lines Coverage Δ
bitswap/bitswap.go 67.05% <100.00%> (-0.39%) ⬇️
bitswap/server/internal/decision/engine.go 91.48% <100.00%> (+0.04%) ⬆️
namesys/republisher/repub.go 61.26% <100.00%> (+2.60%) ⬆️
bitswap/client/client.go 87.93% <81.81%> (-0.14%) ⬇️
bitswap/server/server.go 61.53% <85.71%> (-3.24%) ⬇️
bootstrap/bootstrap.go 30.90% <39.62%> (-1.05%) ⬇️

... and 8 files with indirect coverage changes

@gammazero gammazero requested a review from hsanjuan November 4, 2024 16:31
@gammazero gammazero marked this pull request as ready for review November 4, 2024 19:23
@gammazero gammazero requested a review from a team as a code owner November 4, 2024 19:23
Copy link
Contributor

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super happy to see goprocess no more. I believe this is good, I hope I'm not missing something. We should pay attention to goroutine leakage when rolling out RCs in case something is not getting closed as before, but it should be fine.

bitswap/server/server.go Outdated Show resolved Hide resolved
@gammazero gammazero requested review from hsanjuan and removed request for hsanjuan November 5, 2024 20:32
@hsanjuan
Copy link
Contributor

hsanjuan commented Nov 6, 2024

Lastest commit LGTM too

The dependency on goprocess is not needed by boxo, and removing it removes the need to support it in code dependent on boxo.

Closes #709
@gammazero gammazero merged commit 625aadd into main Nov 7, 2024
17 checks passed
@gammazero gammazero deleted the no-goprocess branch November 7, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on goprocess
2 participants