-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on goprocess #710
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #710 +/- ##
==========================================
- Coverage 60.38% 60.35% -0.03%
==========================================
Files 243 243
Lines 31025 31021 -4
==========================================
- Hits 18733 18724 -9
- Misses 10625 10633 +8
+ Partials 1667 1664 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super happy to see goprocess no more. I believe this is good, I hope I'm not missing something. We should pay attention to goroutine leakage when rolling out RCs in case something is not getting closed as before, but it should be fine.
Lastest commit LGTM too |
The dependency on goprocess is not needed by boxo, and removing it removes the need to support it in code dependent on boxo. Closes #709
069d6bf
to
19d1d6b
Compare
The dependency on goprocess is not needed by boxo, and removing it removes the need to support it in code dependent on boxo.
Closes #709