Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockservice: don't store allowlist in Session #554

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jan 15, 2024

This is accessible through the blockservice object.

This is accessible through the blockservice object.
@Jorropo Jorropo requested a review from a team as a code owner January 15, 2024 05:55
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ea04c77) 65.50% compared to head (ff4f785) 65.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
+ Coverage   65.50%   65.52%   +0.01%     
==========================================
  Files         207      207              
  Lines       25619    25622       +3     
==========================================
+ Hits        16783    16789       +6     
+ Misses       7360     7355       -5     
- Partials     1476     1478       +2     
Files Coverage Δ
blockservice/blockservice.go 75.25% <93.33%> (-0.09%) ⬇️

... and 11 files with indirect coverage changes

Copy link
Contributor Author

Jorropo commented Jan 15, 2024

Merge activity

  • Jan 15, 2:53 AM: @Jorropo started a stack merge that includes this pull request via Graphite.
  • Jan 15, 2:54 AM: @Jorropo merged this pull request with Graphite.

@Jorropo Jorropo merged commit 2f67c04 into main Jan 15, 2024
15 of 16 checks passed
@Jorropo Jorropo deleted the 01-15-blockservice_don_t_store_allowlist_in_Session branch January 15, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant