Merge pull request #77 from smortex/eql

Make eql? behare like ==.
ipaddress-gem · Jan 8, 2022 · 8ff186b · 8ff186b
2 parents 85b95ef + 9b8d8fd
commit 8ff186b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 0 deletions.
diff --git a/lib/ipaddress/ipv4.rb b/lib/ipaddress/ipv4.rb
@@ -515,6 +515,7 @@ def <=>(oth)
       return prefix <=> oth.prefix if to_u32 == oth.to_u32  
       to_u32 <=> oth.to_u32
     end
+    alias eql? ==
 
     #
     # Returns the number of IP addresses included

diff --git a/lib/ipaddress/ipv6.rb b/lib/ipaddress/ipv6.rb
@@ -528,6 +528,7 @@ def <=>(oth)
       return prefix <=> oth.prefix if to_u128 == oth.to_u128  
       to_u128 <=> oth.to_u128
     end
+    alias eql? ==
 
     #
     # Returns the address portion of an IP in binary format,

diff --git a/test/ipaddress/ipv4_test.rb b/test/ipaddress/ipv4_test.rb
@@ -387,8 +387,10 @@ def test_method_compare
     assert_equal false, ip3 < ip1
     # ip1 should be equal to itself
     assert_equal true, ip1 == ip1
+    assert_equal true, ip1.eql?(ip1)
     # ip1 should be equal to ip4
     assert_equal true, ip1 == ip4
+    assert_equal true, ip1.eql?(ip4)
     # test sorting
     arr = ["10.1.1.1/8","10.1.1.1/16","172.16.1.1/14"]
     assert_equal arr, [ip1,ip2,ip3].sort.map{|s| s.to_string}

diff --git a/test/ipaddress/ipv6_test.rb b/test/ipaddress/ipv6_test.rb
@@ -325,6 +325,11 @@ def test_method_compare
     assert_equal false, ip3 < ip1
     # ip1 should be equal to itself
     assert_equal true, ip1 == ip1
+    assert_equal true, ip1.eql?(ip1)
+    # ip1 should be equal to a copy of itself
+    other = ip1.dup
+    assert_equal true, ip1 == other
+    assert_equal true, ip1.eql?(other)
     # ip4 should be greater than ip1
     assert_equal true, ip1 < ip4
     assert_equal false, ip1 > ip4