Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pw70 description #167

Merged
merged 3 commits into from
Sep 13, 2016
Merged

Pw70 description #167

merged 3 commits into from
Sep 13, 2016

Conversation

destogl
Copy link
Contributor

@destogl destogl commented May 30, 2016

Added description and visualisation for Powercube PW70 modules. Is is tested in both configurations "upsidedown" and normal one.

<mesh filename="package://schunk_description/meshes/pw70/pw70_square_holder.stl" />
</geometry>
</visual>
<!-- <collision>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the collision model commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We left it commented out since it is not well tested. We use the same description as for the visualisation and I am not sure that is the right thing. In this way there is a place holder when someone will work with collisions.

@destogl
Copy link
Contributor Author

destogl commented Jun 10, 2016

@ipa-nhg should I change here something to get it merged or something else?

@ipa-nhg
Copy link
Member

ipa-nhg commented Sep 7, 2016

@destogl could you please add the collisions of the links?

@ipa-nhg
Copy link
Member

ipa-nhg commented Sep 13, 2016

thanks @destogl

FR: OK

@ipa-nhg ipa-nhg merged commit 9826032 into ipa320:indigo_dev Sep 13, 2016
@destogl destogl deleted the pw70_description branch September 13, 2016 14:20
@manuelmuehlig
Copy link

Hi, could you please tell me how you tested the PW70. I assumed that it uses the Schunk Motion Protocol for communication instead of the Amtec protocol. Are they compatible?

@destogl
Copy link
Contributor Author

destogl commented May 11, 2017

@manuelmuehlig our PW70 modules uses Amtec protocol. I wanted to create PR with launch files for a long time. I will add it soon so you can check it.

SMP and Amtec protocol are not compatible.

@manuelmuehlig
Copy link

@destogl Launch files would be great. I now understand the differences between SMP and Amtec and was able to get our PW 70 running with SocketCAN and SMP. If you could submit the launch files for your PW 70 with the old protocol I would likely be able to adapt everything to also support SMP. Although the communication is different, the basic control seems very similar.

@destogl
Copy link
Contributor Author

destogl commented May 22, 2017

@manuelmuehlig
Copy link

Thanks, that helps getting things started. I am still considering how to tackle the SMP communication (see #187 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants