Namespace harmonization to private node handles and debug display improvement #103
Conversation
…into indigo_dev
|
The change with the namespaces is a proposal, by the way. I prefer it like that, but if the majority does not like it, we can stay with what we have. |
| std::string polygon_service_name = "/map_accessibility_analysis/map_polygon_accessibility_check"; | ||
| std::string points_service_name = "/map_accessibility_analysis/map_accessibility_analysis/map_points_accessibility_check"; | ||
| std::string perimeter_service_name = "/map_accessibility_analysis/map_accessibility_analysis/map_perimeter_accessibility_check"; | ||
| std::string polygon_service_name = "/map_accessibility_analysis/map_accessibility_analysis/map_polygon_accessibility_check"; |
There was a problem hiding this comment.
you could simply remove the ns="map_accessibility_analysis" in the launch file to achieve backwards-compatibility wrt the resulting namespace...
There was a problem hiding this comment.
I thought it was with double namespace before. But that's fine, I will change that.
There was a problem hiding this comment.
advertising the topic under the - now private - nodehandle changed the topic/service names advertised by the server (because the nodename itself is now prepended to the topic)...see also that you had to add the extra namespace to the client...!
so for compatibility with external applications you need to keep topic/service namespace as they were before....
if you like the parameters in the private namespace you have to remove the external ns of the node...
I did not encounter any differences in usage with my applications, please test if your applications run likewise as before.