feat(node): add apis package #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitofun
force-pushed
the
feat/node_apis
branch
2 times, most recently
from
ff7f3a9 to
9f30cf9
Compare
saitofun
force-pushed
the
feat/node_apis
branch
from
9f30cf9 to
9bbfa06
Compare
huangzhiran
reviewed
Nov 16, 2023
cmd/node/apis/apis.go
Outdated
| } | ||
|
|
||
| func (s *Server) Run() error { | ||
| s.engine.POST("/message", s.handleRequest) |
There was a problem hiding this comment.
del this line, run shouldn't have path register logic
cmd/node/apis/types.go
Outdated
|
|
||
| type errResp struct { | ||
| type HandleErrRsp struct { |
There was a problem hiding this comment.
use errResp ? handle is verb, maybe not suitable for struct name, but for function name.
rename to private
cmd/node/apis/types.go
Outdated
| } | ||
|
|
||
| type msgReq struct { | ||
| type HandleReq struct { |
vm/type.go
Outdated
| type Type string | ||
|
|
||
| const ( | ||
| Risc0 Type = "risc0" | ||
| Halo2 Type = "halo2" | ||
| ) | ||
|
|
||
| var vmEndpointConfigEnvKeyMap = map[string]Type{ |
There was a problem hiding this comment.
same not used in this pr, maybe can added when is used
huangzhiran
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.