feat(vm): default vm handler #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderZhi
reviewed
Nov 14, 2023
Comment on lines
+45
to
+56
| var DefaultHandler *Handler | ||
|
|
||
| func init() { | ||
| var endpoints = make(map[Type]string) | ||
| for key, typ := range vmEndpointConfigEnvKeyMap { | ||
| if ep := viper.GetString(key); ep != "" { | ||
| endpoints[typ] = ep | ||
| } | ||
| } | ||
|
|
||
| DefaultHandler = NewHandler(endpoints) | ||
| } |
There was a problem hiding this comment.
why we need it be initialized in init?
There was a problem hiding this comment.
I tried to initialize a default vm handler, if the vm endpoint can be read from env. And then the vm.DefaultHandler will be used to initialize the msg.DefaultHandler.
There was a problem hiding this comment.
if some module don't need the default handler, they can create a hander by NewHander
There was a problem hiding this comment.
i think default if unnecessary， just NewHandler is more clear
saitofun
force-pushed
the
feat/vm/default_handler
branch
from
19b6fa0 to
ddf787d
Compare
saitofun
force-pushed
the
feat/vm/default_handler
branch
from
ddf787d to
5d80cd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.