-
Notifications
You must be signed in to change notification settings - Fork 338
Disable special address #4537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Disable special address #4537
Conversation
if addrStr == address.RewardingPoolAddr || addrStr == address.StakingBucketPoolAddr { | ||
return core.getProtocolAccount(ctx, addrStr) | ||
} | ||
span.AddEvent("accountutil.AccountStateWithHeight") | ||
addr, err := address.FromString(addrStr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addrStr is 0x encode format from web3 request, instead of io encode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in latest commit
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4537 +/- ##
==========================================
- Coverage 74.83% 72.96% -1.88%
==========================================
Files 378 385 +7
Lines 31624 32904 +1280
==========================================
+ Hits 23666 24007 +341
- Misses 6747 7664 +917
- Partials 1211 1233 +22 ☔ View full report in Codecov by Sentry. |
Description
Special address (rewarding pool and staking bucket pool) is not allowed as transaction address
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: