[nodeinfo] add p2p address into metrics

[dustinxie]

Description

add p2p address into metrics. In case of need, we can follow the p2p address to find the node's IP address

Fixes #3956

Type of change

Please delete options that are not relevant.

• [] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• [] Code refactor or improvement
• [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
• [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• make test
• [] fullsync
• [] Other test (please specify)

Test Configuration:

• Firmware version:
• Hardware:
• Toolchain:
• SDK:

Checklist:

• [] My code follows the style guidelines of this project
• [] I have performed a self-review of my code
• [] I have commented my code, particularly in hard-to-understand areas
• [] I have made corresponding changes to the documentation
• [] My changes generate no new warnings
• [] I have added tests that prove my fix is effective or that my feature works
• [] New and existing unit tests pass locally with my changes
• [] Any dependent changes have been merged and published in downstream modules

[sonarqubecloud]

Quality Gate failed

Failed conditions
4.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1f0636) 75.38% compared to head (faa6e21) 76.30%.
Report is 173 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4143      +/-   ##
==========================================
+ Coverage   75.38%   76.30%   +0.92%     
==========================================
  Files         303      339      +36     
  Lines       25923    28870    +2947     
==========================================
+ Hits        19541    22030    +2489     
- Misses       5360     5734     +374     
- Partials     1022     1106      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Liuhaai]

one gauge is enough?

[dustinxie]

it is for grafana transition. I also thought just add p2pID into existing gauge, but would that cause data error on grafana? nodes with new version have 3 labels in the gauge, while nodes with current version still have 2 labels in the gauge

[Liuhaai]

i don't think there would be error on grafana, but you can test it.

[envestcc]

Should work well using one gauge