feat(ioctl): project state and operator subcommands #4024
Conversation
saitofun
requested review from
CoderZhi,
dustinxie,
Liuhaai and
a team
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4024 +/- ##
==========================================
+ Coverage 75.38% 76.20% +0.82%
==========================================
Files 303 338 +35
Lines 25923 28805 +2882
==========================================
+ Hits 19541 21950 +2409
- Misses 5360 5735 +375
- Partials 1022 1120 +98 ☔ View full report in Codecov by Sentry. |
| }, | ||
| } | ||
|
|
||
| wsProjectStartShorts = map[config.Language]string{ |
ioctl/cmd/ws/wsprojectoperator.go
Outdated
| contract, err := util.Address(wsProjectRegisterContractAddress) | ||
| if err != nil { | ||
| return "", output.NewError(output.AddressError, "failed to get project register contract address", err) | ||
| } | ||
|
|
||
| bytecode, err := wsProjectRegisterContractABI.Pack(funcName, projectID, operatorAddr) | ||
| if err != nil { | ||
| return "", output.NewError(output.ConvertError, fmt.Sprintf("failed to pack abi"), err) | ||
| } | ||
|
|
||
| if err = action.Execute(contract, big.NewInt(0), bytecode); err != nil { | ||
| return "", errors.Wrap(err, "failed to execute contract") | ||
| } |
There was a problem hiding this comment.
these code is reused by wsprojectcontrol.go and wsprojectoperator.go, maybe it can be abstracted a another function
There was a problem hiding this comment.
different parameters api.Pack
There was a problem hiding this comment.
here no need to do action.ExecuteAndResponse then waitReceiptByActionHash to check execution result?
…/project_state_and_operator
…tex-core into feat/project_state_and_operator
…/project_state_and_operator
…/project_state_and_operator
ioctl/cmd/ws/wsprojectcontrol.go
Outdated
|
|
||
| wsProjectStopShorts = map[config.Language]string{ | ||
| config.English: "stop w3bstream project", | ||
| config.Chinese: "暂停项目", |
ioctl/cmd/ws/wsprojectoperator.go
Outdated
| wsProjectDelOperatorShorts = map[config.Language]string{ | ||
| config.English: "remove operator to project", | ||
| config.Chinese: "移除项目操作者", | ||
| } |
There was a problem hiding this comment.
these 2 should be put in front?
…/project_state_and_operator
|
Description
ws project state control and operator manage
Type of change
How Has This Been Tested?
Checklist: