fix(iota-data-ingestion-core): make file updates atomic #6918
+103
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
iota-ci
added
infrastructure
kodemartin
approved these changes
May 21, 2025
sergiupopescu199
force-pushed
the
sc-platform/issue-6889
branch
from
3652ae0 to
36aa17e
Compare
samuel-rufi
reviewed
May 21, 2025
samuel-rufi
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR refactors the
FileProgressStoreto ensure atomic updates when storing watermark data.It leverages a temporary file to write the new data, and then uses an atomic rename operation to replace the original file with the updated version.
This approach guarantees that the watermark file is never left in a partially written or corrupted state, even in the event of a crash or unexpected shutdown, ensuring data integrity and reliability.
Links to any relevant issues
fixes #6889
Type of change
How the change has been tested
cargo test -p iota-data-ingestion-coreMake sure to provide instructions for the maintainer as well as any relevant configurations.
iota-data-ingestion-corecrate that verifies the actual patch changesfile_progress_store_save_timeout_simulates_crash&file_progress_storeInfrastructure QA (only required for crates that are maintained by @iotaledger/infrastructure)
Note
The other checkboxes were removed since this patch does not directly affect the indexer performance, nevertheless running locally the ingestion framework for checkpoint processing risulted in the same performance as before, not visible regression were spotted.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.
Release Notes