feat(core, types): add CheckpointData to bcs iota.yaml description file #6912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
alexsporn
changed the title
muXxer
approved these changes
May 20, 2025
| @@ -56,6 +67,13 @@ fn get_registry() -> Result<Registry> { | |||
| // tracer.trace_value(&mut samples, ...)?; | |||
| // with all the base types contained in messages, especially the ones with | |||
| // custom serializers; or involving generics (see [serde_reflection documentation](https://novifinancial.github.io/serde-reflection/serde_reflection/index.html)). | |||
|
|
|||
| let m = ModuleId::new(AccountAddress::ZERO, Identifier::new("foo").unwrap()); | |||
There was a problem hiding this comment.
These lines were originally introduced by 6d8ceed which we didn't port yet. Do you plan to port that commit @iotaledger/vm-language ?
There was a problem hiding this comment.
I was just writing a note about that line:
Note for the reviewers: To be able to apply the upstream changes, I had to add line 71 and the next line myself. Those lines are still in latest upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Upstream range: [v1.34.2, v1.35.4)
Port MystenLabs/sui@68497e3
Add CheckpointData to bcs iota.yaml description file
Links to any relevant issues
Part of #3990
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested