fix(core): Update async-graphql, axum and tonic
#6901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…com/iotaledger/iota into fix/update-async-graphql-axum-tonic
marc2332
changed the title
async-graphql, axum and tonic
…com/iotaledger/iota into fix/update-async-graphql-axum-tonic
marc2332
changed the title
async-graphql, axum and tonicasync-graphql, axum and tonic
DaughterOfMars
approved these changes
May 20, 2025
This was referenced May 20, 2025
kodemartin
requested changes
May 20, 2025
There is a compatibility check that ensures that all relations in |
kodemartin
approved these changes
May 20, 2025
muXxer
reviewed
May 20, 2025
| @@ -68,7 +68,7 @@ impl ApiEndpoint<RestService> for ExecuteTransaction { | |||
| async fn execute_transaction( | |||
| State(state): State<Option<Arc<dyn TransactionExecutor>>>, | |||
| Query(parameters): Query<ExecuteTransactionQueryParameters>, | |||
| client_address: Option<axum::extract::ConnectInfo<SocketAddr>>, | |||
| client_address: Result<axum::extract::ConnectInfo<SocketAddr>, ExtensionRejection>, | |||
There was a problem hiding this comment.
why did we change that one?
There was a problem hiding this comment.
Its an axum change, it does no longer take an Option, but instead it takes a Result now. Took me some time to figure out why, ended up in tokio-rs/axum#3245 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6886
In order to use the latest
async-graphql,axumandtonicalso need to be updated in our codebase, otherwise it would throw the classic "you might be using two versions of the same crate" error asasync-graphql-axumhas moved toaxum0.8since the version we use (7.0.11)Also had to update
tonic-rustls, but this one is not released, so I pinned on bmwill/tonic-rustls@77c3334I removed the
{->:path patcher as{}is the correct syntax inaxum>0.8I don't think they were going to release a patch over the
7.0.11release ofasync-graphql-axumeither btw, I mean, considering they updated toaxum0.8somewhere in between7.0.11and7.0.16I think it's safe to safe this is anti-semver territoryI didn't want to fork the
7.0.11version and backport the patch, so I went on updating the other depsMaybe you disagree with this and would prefer with a simple fork, but this will just make it harder in the future if other issues come up
[run-ci]