chore(cli): remove useless clap rename #5226
Open
+123
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
iota-ci
added
dev-tools
Alex6323
force-pushed
the
dev-tools/remove-useless-clap-renaming
branch
from
2bab65e to
aa9cb22
Compare
Thoralf-M
approved these changes
Feb 6, 2025
Alex6323
force-pushed
the
dev-tools/remove-useless-clap-renaming
branch
from
90ff90f to
81bfd41
Compare
Alex6323
force-pushed
the
dev-tools/remove-useless-clap-renaming
branch
from
894e324 to
e399634
Compare
Thoralf-M
reviewed
Feb 12, 2025
Thoralf-M
approved these changes
Feb 12, 2025
jkrvivian
approved these changes
Feb 13, 2025
| @@ -28,10 +28,10 @@ struct Args { | |||
| pub package_path: Option<PathBuf>, | |||
| /// If true, run the Move bytecode verifier on the bytecode from a | |||
| /// successful build | |||
| #[arg(long = "path", short = 'p', global = true)] | |||
There was a problem hiding this comment.
This is a breaking change so the PR should be flagged as such
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Removes all instances of pointless
clapargument renames. Renames are considered pointless if they convert underscores to hyphens or if they rename to the same name that the field already has.How the change was tested
cargo run --package iota-move --release -- --helpcargo run --package iota --release -- --helpLinks to any relevant issues
fixes #5166