Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(devx): Add Toggle for Feedback and Quiz Components #5219

Merged
merged 5 commits into from
Feb 14, 2025
Merged

feat(devx): Add Toggle for Feedback and Quiz Components #5219

merged 5 commits into from
Feb 14, 2025
+95 −43

Conversation

lucas-tortora
Copy link
Contributor

@lucas-tortora lucas-tortora commented Feb 5, 2025 •
edited
Loading

Description of change

Added buttons to toggle the quizzes and feedback form on the docs so they don't take up as much space.

Links to any relevant issues

fixes #5099
fixes #5098

Type of change

  • Enhancement (a non-breaking change which adds functionality)
  • Documentation Fix

How the change has been tested

Docs were built locally.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@lucas-tortora lucas-tortora requested a review from a team as a code owner February 5, 2025 16:49
@vercel Vercel
Copy link

vercel bot commented Feb 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-backend ⬜️ Skipped (Inspect) Feb 14, 2025 1:37pm
apps-ui-kit ⬜️ Skipped (Inspect) Feb 14, 2025 1:37pm
rebased-explorer ⬜️ Skipped (Inspect) Feb 14, 2025 1:37pm
wallet-dashboard ⬜️ Skipped (Inspect) Feb 14, 2025 1:37pm

@iota-ci iota-ci added the devx Issues related to the DevX team label Feb 5, 2025
@lucas-tortora lucas-tortora added documentation Improvements or additions to documentation dx-documentation For TW or documentation related issues. labels Feb 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

✅ Vercel Preview Deployment is ready!

View Preview

Ginowine
Ginowine approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@Ginowine Ginowine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it out, it works very well. Very helpful feature.

vivekjain23
vivekjain23 reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@vivekjain23 vivekjain23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments, everything LGTM.

vivekjain23
vivekjain23 reviewed Feb 11, 2025
View reviewed changes
docs/site/src/components/FeedbackForm/index.tsx Outdated Show resolved Hide resolved
docs/site/src/components/FeedbackForm/index.tsx Outdated Show resolved Hide resolved
docs/site/src/components/FeedbackForm/index.tsx Show resolved Hide resolved
docs/site/src/components/Quiz/index.tsx Outdated Show resolved Hide resolved
docs/site/src/components/Quiz/index.tsx Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – apps-ui-kit February 11, 2025 11:04 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend February 11, 2025 11:04 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer February 11, 2025 11:04 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard February 11, 2025 11:04 Inactive
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@vercel vercel bot temporarily deployed to Preview – rebased-explorer February 14, 2025 13:37 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-ui-kit February 14, 2025 13:37 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend February 14, 2025 13:37 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard February 14, 2025 13:37 Inactive
@github-actions GitHub Actions
Copy link
Contributor

✅ Vercel Preview Deployment is ready!

View Preview

@lucas-tortora lucas-tortora merged commit cf04099 into develop Feb 14, 2025
35 checks passed
@lucas-tortora lucas-tortora deleted the devx/hide-feedback-and-quizzes branch February 14, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ginowine Ginowine Ginowine approved these changes

@vivekjain23 vivekjain23 vivekjain23 approved these changes

Assignees
No one assigned
Labels
devx Issues related to the DevX team documentation Improvements or additions to documentation dx-documentation For TW or documentation related issues.
Projects
None yet
Milestone
No milestone
4 participants
@lucas-tortora @Ginowine @vivekjain23 @iota-ci