-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iota-framework/move-stdlib): Deprecated fixed_point32
#5193
base: vm-lang/upstream-nov-dic-24
Are you sure you want to change the base?
feat(iota-framework/move-stdlib): Deprecated fixed_point32
#5193
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the CI error:
thread 'compatibility_tests::test_framework_compatibility' panicked at crates/iota-framework-snapshot/tests/compatibility_tests.rs:37:21: The current IOTA framework 0x000000000000000000000000000000000000000000000000000000000000107a is not compatible with version 1
It probably means that we use fixed_point32
there and we need to change it to uq32_32
.
@miker83z @Dkwcs Looks like it is because the |
royalties: VecMap<address, FixedPoint32>, | ||
royalties: VecMap<address, UQ32_32>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FixedPoint32
and UQ32_32
structures are compatible on the binary level but I think we still need to change the member type in the Irc27Metadata
structure on the Rust side.
Since the |
Description of change
fixed_point32
uq32_32
to replace itMove
fixed_point32
has been deprecated for a newuq32_32
moduleLinks to any relevant issues
Fixes #5137 .
Type of change
How the change has been tested
Run in folder:
iota-framework/packages/move-stdlib/
iota-framework/packages/stardust/
iota-framework/packages/iota-framework/
iota move test
iota-framework-tests:
cargo test