Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Hornet net config supplied by .env #1249

Closed

Conversation

trungtt198x
Copy link
Contributor

@trungtt198x trungtt198x commented Aug 24, 2023

Add the ability to specify Hornet net config JSON file that is supplied by the .env.
This is to avoid direct editing the file docker\docker-compose.yml.
So, in the .env, a new param HORNET_CONFIG_PATH is introduced.

Copy link
Collaborator

@DaughterOfMars DaughterOfMars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to add the variable to the example .env

EDIT: I guess there is no example file, so maybe just add it to the README section.

@trungtt198x
Copy link
Contributor Author

I think we also need to add the variable to the example .env

EDIT: I guess there is no example file, so maybe just add it to the README section.

I added a template file .env.template that should be OK

.env.template Outdated Show resolved Hide resolved
Co-authored-by: Alexandcoats <[email protected]>
@DaughterOfMars
Copy link
Collaborator

Can you add it to the README as well?

@trungtt198x
Copy link
Contributor Author

Can you add it to the README as well?

added

.env.template Outdated Show resolved Hide resolved
@DaughterOfMars
Copy link
Collaborator

Oh, you need to sign your commits, please.

@trungtt198x
Copy link
Contributor Author

Oh, you need to sign your commits, please.

what do you mean by sign the commits ??

@DaughterOfMars
Copy link
Collaborator

@trungtt198x
Copy link
Contributor Author

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

This repo requires all commits to be signed.

Can I still sign the commits that are already pushed?
I realize that I use 2 different github accounts !!
If I use the github account that is same as the one creating the PR, then do I still need to sign.

Maybe, I should close this PR and then open another PR with only 1 github account for commit?

@trungtt198x trungtt198x deleted the chore/add-env-hornet-net branch August 24, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants