-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify Hornet net config supplied by .env #1249
Conversation
Co-authored-by: Alexandcoats <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to add the variable to the example .env
EDIT: I guess there is no example file, so maybe just add it to the README section.
…1981/inx-chronicle into chore/add-env-hornet-net
I added a template file |
Co-authored-by: Alexandcoats <[email protected]>
Can you add it to the README as well? |
added |
Oh, you need to sign your commits, please. |
what do you mean by |
https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits This repo requires all commits to be signed. |
Can I still sign the commits that are already pushed? Maybe, I should close this PR and then open another PR with only 1 github account for commit? |
Add the ability to specify Hornet net config JSON file that is supplied by the .env.
This is to avoid direct editing the file
docker\docker-compose.yml
.So, in the .env, a new param
HORNET_CONFIG_PATH
is introduced.