Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC binding build issues #1483

Merged

Conversation

wulfraem
Copy link
Contributor

@wulfraem wulfraem commented Dec 5, 2024

Description of change

  • fixes outdated .create_identity arguments
  • replaces deprecated get_public_key calls with get_public_key_with_type

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Checked build locally, with opening the PR against main tests will be fired with the correct CI steps.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wulfraem wulfraem added No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. gRPC Related to the gRPC bindings code labels Dec 5, 2024
@wulfraem wulfraem requested a review from a team as a code owner December 5, 2024 06:58
@wulfraem wulfraem changed the base branch from main to feat/identity-rebased-alpha December 5, 2024 07:54
@wulfraem wulfraem marked this pull request as draft December 5, 2024 10:36
@wulfraem wulfraem marked this pull request as ready for review December 5, 2024 10:36
@wulfraem wulfraem changed the base branch from feat/identity-rebased-alpha to main December 5, 2024 10:36
@wulfraem wulfraem marked this pull request as draft December 5, 2024 10:36
@wulfraem wulfraem marked this pull request as ready for review December 5, 2024 10:36
@wulfraem wulfraem changed the base branch from main to feat/identity-rebased-alpha December 5, 2024 11:17
@eike-hass eike-hass merged commit 607a03e into feat/identity-rebased-alpha Dec 5, 2024
17 checks passed
@eike-hass eike-hass deleted the feat/fix-grpc-binding-build-issues branch December 5, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gRPC Related to the gRPC bindings code No changelog Excludes PR from becoming part of any changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants