Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: crash on lost node connection #8533

Merged
merged 3 commits into from
May 17, 2024
Merged

hotfix: crash on lost node connection #8533

merged 3 commits into from
May 17, 2024

Conversation

marc2332
Copy link
Collaborator

@marc2332 marc2332 commented May 17, 2024 •
edited by begonaalvarezd
Loading

Closes #8534
Closes #8530

@marc2332 marc2332 linked an issue May 17, 2024 that may be closed by this pull request
[Task]: Handle network name being empty when there is no connection #8534
Closed
@marc2332 marc2332 marked this pull request as ready for review May 17, 2024 08:35
@marc2332 marc2332 requested review from begonaalvarezd and cpl121 May 17, 2024 08:35
@begonaalvarezd begonaalvarezd changed the title fx: Handle empty network name hotfix: crash on lost node connection May 17, 2024
@begonaalvarezd begonaalvarezd linked an issue May 17, 2024 that may be closed by this pull request
[Bug report]: Firefly Canary freezes after some time of using #8530
Closed
2 tasks
@begonaalvarezd begonaalvarezd merged commit 84ed7b1 into canary May 17, 2024
5 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/handle-empty-network-name branch May 17, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@cpl121 cpl121 Awaiting requested review from cpl121

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@marc2332 @begonaalvarezd