Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding year to asset inventory webpage #86

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

MathewBiddle
Copy link
Contributor

The asset inventory webpage is only showing the inventory for the most recent year. This PR adds the calendar year the webpage is presenting to the descriptive text of the page.

@MathewBiddle
Copy link
Contributor Author

@ocefpaf mind taking a look at this?

@@ -192,6 +193,7 @@ def main(org_config):
configs = {
"table": gdf.to_html(table_id="table", index=False, columns=columns),
"figure": fig,
"year": gdf['Year'].unique()[0]
Copy link
Member

@ocefpaf ocefpaf Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are getting the first occurrence of Year, so you probably don't need the .unique() there, right? I don't know what that gdf is, I need to run this script first, but if the Year value is the same everywhere and/or what you need is just the first occurrence, this is good to go.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes. I was just pulling the string out of the list so it was easier to show on the website.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I don't have enough rights to merge this but it is good IMO.
Also, I sent #87 to help with reviews on the page generation in the future.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 4, 2024

@MathewBiddle is https://erddap.ioos.us/erddap down? I'm trying to test the script locally but I cannot reach it.

@MathewBiddle
Copy link
Contributor Author

should be back up now. Don't know what went wrong. https://erddap.ioos.us/erddap/index.html

@MathewBiddle MathewBiddle merged commit 2a34ba3 into ioos:main Jul 4, 2024
3 checks passed
@MathewBiddle MathewBiddle deleted the add_yr_AI branch July 4, 2024 14:03
@ocefpaf
Copy link
Member

ocefpaf commented Jul 4, 2024

should be back up now. Don't know what went wrong. https://erddap.ioos.us/erddap/index.html

Shouldn't you be on holiday today? All these issues can wait. (And sorry for the pings today.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants