Use ioos-qc library in glider_qc.py #289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added an extension in the requirement file to pull in the ioos-qc library package
Fixed the flag name attribute to match ioos-qc definitions Fixed the manual link Added the min and max values for a flag
Modified the script to create qartod variables and add the qartod test results to each qartod variable.
- Changed the required variables to a list of qartod variables. - Made changes to few functions to work accordingly.
fixed spelling detected by the code checks
rectified the omitted quotes in line 611
added 'nc_path' to the run_qc function
commented out an old version of the get_unmasked function
fixed syntax errors added qartod_status attribute
fixed log.info() and log.exception() syntax errors
it did not like the addition log.exception() added to the "except OSError:" when checking os.getxattr() in the previous commit.
extended qartod variables' attributes to include more verbose explanation
added more to log.info for debugging purposes
|
Could you please squash some of these commits down thematically? |
commented out the ioos_qartod git repo that has been deprecated
|
pre-commit fix |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…uild-erddap-xml-w-qartod-vars
…artod-vars merging branches
update branch from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced to the script:
With all files having an initial list of qartods variables the following functions are no longer needed and have been commented out:
find_qc_flags
needs_qc
create_qc_variables
apply_primary_qc
The following function were modified or added to adapt the ioos-qc library methodology:
-- Modified:
apply_qc
run_qc
check_needs_qc
-- Added
update_config
The updated glider_qc.py does the following:
'spike_test',
'rate_of_change_test']
More functionality to verify: