Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Python support 3.10 #1122

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Minimum Python support 3.10 #1122

merged 3 commits into from
Nov 21, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Nov 14, 2024

Python 3.8 reached EOL and while 3.9 will only reach EOL 2025-10, pyudunits2 is py310 only and we should move away from the compiled udunits2 extension.

@benjwadams let me know what you think. Once this one is merged I'm also planning on activating pyupgrade and ruff format and slowly update the code here.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.17%. Comparing base (5c56994) to head (e322674).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
compliance_checker/suite.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1122   +/-   ##
========================================
  Coverage    82.17%   82.17%           
========================================
  Files           25       25           
  Lines         5206     5206           
  Branches      1162     1162           
========================================
  Hits          4278     4278           
  Misses         627      627           
  Partials       301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ocefpaf ocefpaf requested a review from benjwadams November 14, 2024 17:15
@ocefpaf
Copy link
Member Author

ocefpaf commented Nov 15, 2024

@benjwadams I'm planing on merging this one next week. Let me know if you have any concerns/comments.

@ocefpaf ocefpaf merged commit f0bedc7 into ioos:develop Nov 21, 2024
22 of 24 checks passed
@ocefpaf ocefpaf deleted the py310 branch November 21, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant