Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda was clobbering the dev version of compliance-checker #1084

Merged
merged 2 commits into from
May 23, 2024

Conversation

ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented May 23, 2024

We ended up testing against a release compliance-checker instead of the development version.

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.75%. Comparing base (30808b2) to head (0a84ef6).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1084      +/-   ##
===========================================
- Coverage    81.92%   81.75%   -0.17%     
===========================================
  Files           24       25       +1     
  Lines         5172     5224      +52     
  Branches      1237     1253      +16     
===========================================
+ Hits          4237     4271      +34     
- Misses         634      644      +10     
- Partials       301      309       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ocefpaf
Copy link
Member Author

ocefpaf commented May 23, 2024

I'll report the OG faliures upstream. This is working as expected now.

@ocefpaf ocefpaf merged commit 48747c5 into ioos:develop May 23, 2024
26 of 28 checks passed
@ocefpaf ocefpaf deleted the fix_test_against_dev_cc branch May 23, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant