-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some pytest fixes #1056
Some pytest fixes #1056
Conversation
* base.py: Sometimes cfutil is None * protocols/netcdf.py: - Return False right away if content_type is None - Support extended type strings: "application/x-netcdf;ver=4" * suite.py: If text for xml fails, look for netcdf one more time * Convert suite.run() calls to suite.run_all() calls * Update hyrax url * Update thredds url * Add some development notes for troubleshooting tests with pytest using the vcr feature.
pre-commit.ci autofix |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1056 +/- ##
===========================================
- Coverage 82.14% 82.06% -0.08%
===========================================
Files 24 24
Lines 5170 5175 +5
Branches 1242 1245 +3
===========================================
Hits 4247 4247
- Misses 623 626 +3
- Partials 300 302 +2 ☔ View full report in Codecov by Sentry. |
@jcermauwedu I'm not a compliance-checker expert and I did not look too hard. Can you explain what/when/where |
Without the test for There are still some pkg references kicking around too.
|
For the SOS test in test_protocols.py, I set that to skip. I searched for awhile for a working SOS service.
Looking forward to seeing #1039 merged.