fix: newline before module elements #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, as noted in the comments in the |
Nsidorenco
reviewed
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #72.
I basically followed the idea you left in the issue, and thus gave
module_elemprecedence oversequential_expressions. It did take me more time than I'd like to admit to grok what you meant and what I had to do though 😅Now, I added 2 tests to the corpus for these changes. Both tests are failing, but the output doesn't show any deviation in the tree structure, and I loaded the grammar in my editor, it is working fine, so I'm not sure how to proceed. Here is a screenshot to help.
Looking forward to your comments!