Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow loading of projects that are missing imports. #206

Merged
merged 12 commits into from
Apr 21, 2024
Merged

Allow loading of projects that are missing imports. #206

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ed44872
Allow loading of projects that are missing imports.
baronfel Apr 17, 2024
7e07e2c
Add basic test for missing explicit import support
baronfel Apr 20, 2024
18fc319
Get loading missing Imports working for both loaders
baronfel Apr 21, 2024
7c0050a
Isolate loaded projects to a unique collection per-load-request to pr…
baronfel Apr 21, 2024
3d3a331
Dispose the per-request collections
baronfel Apr 21, 2024
40b5458
Unify the logic around safely getting or creating a project in a coll…
baronfel Apr 21, 2024
103824e
No for real safely create a project
baronfel Apr 21, 2024
a7d9807
fix the project-uniqueness comparison
baronfel Apr 21, 2024
f99e8e9
A spot of code cleanup
baronfel Apr 21, 2024
9ab3cd2
better logging and diagnostics
baronfel Apr 21, 2024
967f2c9
CI: fix CI breaks when uploading the same asset (nuget packages in th…
baronfel Apr 21, 2024
74e8b10
Fix logger initialization for the new message
baronfel Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/Ionide.ProjInfo/Library.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@ module ProjectLoader =
and set (v: LoggerVerbosity): unit = ()
}


let internal stringWriterLogger (writer: StringWriter) =
{ new ILogger with
member this.Initialize(eventSource: IEventSource) : unit =
Expand Down Expand Up @@ -530,14 +529,17 @@ module ProjectLoader =
let globalProperties = getGlobalProps path tfm globalProperties

use pc = new ProjectCollection(globalProperties)

let pi = pc.LoadProject(path, globalProperties, toolsVersion = null)
let loadSettings =
ProjectLoadSettings.RecordEvaluatedItemElements
||| ProjectLoadSettings.ProfileEvaluation
||| ProjectLoadSettings.IgnoreMissingImports
let project = Project(projectFile = path, globalProperties = globalProperties, toolsVersion = null, projectCollection = pc, loadSettings = loadSettings)

use sw = new StringWriter()

let loggers = createLoggers [ path ] binaryLogs sw

let pi = pi.CreateProjectInstance()
let pi = project.CreateProjectInstance()

let build = pi.Build(designTimeBuildTargets isLegacyFrameworkProjFile, loggers)

Expand Down Expand Up @@ -1030,6 +1032,7 @@ type WorkspaceLoaderViaProjectGraph private (toolsPath, ?globalProperties: (stri
buildParameters.ProjectLoadSettings <-
ProjectLoadSettings.RecordEvaluatedItemElements
||| ProjectLoadSettings.ProfileEvaluation
||| ProjectLoadSettings.IgnoreMissingImports

buildParameters.LogInitialPropertiesAndItems <- true
bm.BeginBuild(buildParameters)
Expand Down
Loading