Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite invokeMSBuild in terms of new invokeMSBuildWithCancel #1913

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Rewrite invokeMSBuild in terms of new invokeMSBuildWithCancel #1913

merged 1 commit into from
Aug 21, 2023

Conversation

farlee2121
Copy link
Contributor

WHAT

Unify invokeMSBuild and invokeMSBuildWithCancel to call back to the same core implementation.

WHY

Because @baronfel pointed out that I forgot to do it in my previous PR

HOW

invokeMSBuild creates a cancellation token so it can call invokeMSBuildWithCancel

@farlee2121 farlee2121 mentioned this pull request Aug 21, 2023
Merged
baronfel
baronfel approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@baronfel baronfel merged commit b43784a into ionide:main Aug 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farlee2121 @baronfel