Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react: add docs for excludeServerSideRenderingFor option #1494

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Nov 5, 2024

Companion PR for ionic-team/stencil-ds-output-targets#540

I also removed the note saying that SSR support only works for Next.js App Router which is not true. The type of router shouldn't matter as long as the user uses Next.js v13 and above.

@christian-bromann christian-bromann requested a review from a team as a code owner November 5, 2024 23:55
@christian-bromann christian-bromann requested review from gnbm and tanner-reits and removed request for a team November 5, 2024 23:55
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stencil-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2024 10:10pm

Copy link
Member

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tweak, non blocking

docs/framework-integration/react.md Outdated Show resolved Hide resolved
@christian-bromann christian-bromann merged commit cc15322 into main Nov 7, 2024
5 checks passed
@christian-bromann christian-bromann deleted the cb/excludeServerSideRenderingFor branch November 7, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants