Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #75

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #75

wants to merge 1 commit into from

Conversation

jthoms1
Copy link
Contributor

@jthoms1 jthoms1 commented Apr 18, 2023

This documentation is meant to make it clear that web builds need to occur before the web build.

Copy link
Member

@carlpoole carlpoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just recommending some changes when split into iOS and Android

npm run build
```

### 4. Build and run the Android app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### 4. Build and run the Android app
### 4. Build and run the iOS app

## Android
### Portals registration key
### 3. Build the web apps
Before you build the iOS or Android source you will need to build the web resources in the `web` and `featured-component` directories:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Before you build the iOS or Android source you will need to build the web resources in the `web` and `featured-component` directories:
Before you build the iOS source you will need to build the web resources in the `web` and `featured-component` directories:


### 2. Build the web apps
Before you build the iOS or Android source you will need to build the web resources in the `web` and `featured-component` directories:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Before you build the iOS or Android source you will need to build the web resources in the `web` and `featured-component` directories:
Before you build the Android source you will need to build the web resources in the `web` and `featured-component` directories:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants