-
Notifications
You must be signed in to change notification settings - Fork 13.5k
fix(tokens): review the generation of utility-classes #30498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BenOsodrac
wants to merge
6
commits into
next
Choose a base branch
from
ROU-11897
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+477
−1,158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thetaPC
requested changes
Jun 18, 2025
...s-snapshots/accordion-group-expand-inset-expanded-ionic-md-ltr-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...r.e2e.ts-snapshots/progress-bar-shape-rectangular-ionic-md-ltr-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
...roup.e2e.ts-snapshots/accordion-group-shape-round-ionic-md-ltr-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
.../searchbar.e2e.ts-snapshots/searchbar-shape-round-ionic-md-ltr-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...st/basic/tab-bar.e2e.ts-snapshots/tab-bar-default-ionic-md-ltr-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
...ab-bar.e2e.ts-snapshots/tab-bar-shape-rectangular-ionic-md-ltr-light-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
Hi @thetaPC, great point, thanks! Updated on all places 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently some utility-classes are not as effective as they could be, because they don't affect, for example, the --background or --color css API's.
What is the new behavior?
Does this introduce a breaking change?