Skip to content

fix(tokens): review the generation of utility-classes #30498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: next
Choose a base branch
from

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Jun 18, 2025

Issue number: internal


What is the current behavior?

Currently some utility-classes are not as effective as they could be, because they don't affect, for example, the --background or --color css API's.

What is the new behavior?

  • Changed the way the classes are generated, so that it affects the css custom properties as well.
  • Make the background classes to only be generated for the tokens that contain 'bg'.
  • Update the style for the body background on the ionic theme (this triggered some snapshots differences).

Does this introduce a breaking change?

  • Yes
  • No

@BenOsodrac BenOsodrac added package: core @ionic/core package type: bug a confirmed bug report labels Jun 18, 2025
Copy link

vercel bot commented Jun 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 7:59am

@BenOsodrac BenOsodrac requested a review from thetaPC June 18, 2025 17:06
@BenOsodrac BenOsodrac marked this pull request as ready for review June 18, 2025 17:06
@BenOsodrac BenOsodrac requested a review from a team as a code owner June 18, 2025 17:06
@BenOsodrac
Copy link
Contributor Author

Hi @thetaPC, great point, thanks! Updated on all places 👍

@BenOsodrac BenOsodrac requested a review from thetaPC June 20, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants