feat(action-sheet): Add cancelable parameter #2285
Open
+89
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only is applied if no cancel option is provided. References: https://outsystemsrd.atlassian.net/browse/RMET-3576
OS-pedrogustavobilro
requested review from
jcesarmobile,
ItsChaceD,
IT-MikeS,
alexgerardojacinto,
OS-ricardomoreirasilva and
OS-martacarlos
|
Released dev build of action-sheet with dev version: 7.0.0-dev-2285-20250113T110659.0 |
| @@ -17,21 +17,26 @@ public class ActionSheetPlugin: CAPPlugin, CAPBridgedPlugin { | |||
| @objc func showActions(_ call: CAPPluginCall) { | |||
| let title = call.options["title"] as? String | |||
| let message = call.options["message"] as? String | |||
| let cancelable = call.options["cancelable"] as? Bool ?? false | |||
There was a problem hiding this comment.
I believe there's a getBool with a default value within the CAPPluginCall, maybe we can use it.
There was a problem hiding this comment.
Isn't there a getString as well?
There was a problem hiding this comment.
But those @OS-pedrogustavobilro didn't change, so I'm not sure if they're worth the change.
There was a problem hiding this comment.
Not super important, but I think if we change one we should change the others to keep the way we access CAPPluginCall's parameters consistent.
There was a problem hiding this comment.
Done in 99443ae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameter to allow action-sheet to be cancelable (clicking outside the sheet, and using the system back button on Android), and in case it is canceled, return it in the result.
Notes:
ActionSheetButtonStyleproperty that other platforms do not - explained in the doc updates that are also in this PR.Fixes #2154