fix(keyboard): Remove iOS keyboard delay (#1904) #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix aligns with the Android implementation of no delay. This fix removes all keyboard delay, including the 0.01 second delay for hiding. I believe this delay existed due to a slight flicker observed when setting delay to 0. However, by wrapping the height javascript logic in `requestAnimationFrame()` the flicker is no longer present. I believe this is a better solution than ionic-team#2230 because it avoids adding animations. (Users can do this themselves by disabling resizing and hooking into keyboardWillShow, didShow, willHide, and didHide events in javascript.) It also avoids magic/arbitrary delay amounts, like 0.01.
theproducer
approved these changes
Nov 26, 2024
theproducer
requested review from
andredestro,
markemer,
EiyuuZack,
Chuckytuh,
jcesarmobile and
eric-horodyski
|
Is it possible to fix the CI? |
markemer
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix aligns with the Android implementation of no delay.
This fix removes all keyboard delay, including the 0.01 second delay for hiding. I believe this delay existed due to a slight flicker observed when setting delay to 0. However, by wrapping the height javascript logic in
requestAnimationFrame()the flicker is no longer present.I believe this is a better solution than #2230 because it avoids adding animations. (Users can do this themselves by disabling resizing and hooking into keyboardWillShow, didShow, willHide, and didHide events in javascript. Also, if and when an animation is added, should also be added to Android too.)
It also avoids magic/arbitrary delay amounts, like 0.01.
Issue reference: #1904.