-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
This change requires |
admin/js/comClasses.js
Outdated
@@ -217,7 +217,8 @@ var comclasses = { | |||
0x2F: {name: 'ZIP_ADV_SERVICES', role: ''}, | |||
0x2e: {name: 'ZIP_CLIENT', role: ''}, | |||
0x24: {name: 'ZIP_SERVER', role: ''}, | |||
0x23: {name: 'ZIP_SERVICES', role: ''} | |||
0x23: {name: 'ZIP_SERVICES', role: ''}, | |||
0x5B: {name: 'CENTRAL_SCENE', role: ''} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to double check if there is a definition for all command classes, see
https://github.com/AlCalzone/node-zwave-js/blob/master/src/lib/commandclass/CommandClasses.ts#L4 for reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, remaining com classes added.
I fear this will create a lot of issues when the people don't know that the fixer is a prerequisite. |
No. I wouldn't know a foolsafe way to forward such a prompt to the admin UI. The better approach would be ioBroker/ioBroker.js-controller#348 IMO - which means that each adapter specifies what root commands it needs. The js-controller would have to allow those (manage permissions) and then |
…nge. Add more com classes
Reverted ldconfig change for now |
Ready from my side, the travis errors are just the usual strange host not found issues |
@AlCalzone or @Apollon77 can you merge if you are fine with that change please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I squash-merged, so please make sure to use a new branch for your next changes or reset it to the current master |
Version increase